Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add basic tests + type hinting + docstring + docs #69

Closed
5 tasks done
hugsy opened this issue May 31, 2023 · 1 comment
Closed
5 tasks done

Add basic tests + type hinting + docstring + docs #69

hugsy opened this issue May 31, 2023 · 1 comment
Assignees
@hugsy
Labels
ci/cd documentation Improvements or additions to documentation help wanted Extra attention is needed priority:medium quality
Milestone
0.1

Comments

@hugsy
Copy link
Owner

hugsy commented May 31, 2023 •
edited
Loading

Last tasks before 0.1:
@hugsy hugsy added this to the 0.1 milestone May 31, 2023
@hugsy hugsy added help wanted Extra attention is needed quality labels May 31, 2023
@hugsy hugsy modified the milestones: 0.1, Next Jun 21, 2023
@hugsy hugsy changed the title Add type hinting Add type hinting + docstring + docs Jun 26, 2023
@hugsy hugsy added documentation Improvements or additions to documentation priority:medium labels Jun 26, 2023
@hugsy hugsy changed the title Add type hinting + docstring + docs Add basic tests + type hinting + docstring + docs Jun 29, 2023
@hugsy hugsy self-assigned this Jun 29, 2023
@hugsy hugsy added the ci/cd label Jun 29, 2023
hugsy pushed a commit that referenced this issue Jun 29, 2023
part of #69 fixed all linting errors/warnings in ctfhub/helpers.poy
1959c50
hugsy added a commit that referenced this issue Jun 29, 2023
@hugsy
Add initial tests (#81)
092724c 
* when `USE_INTERNAL_HEDGEDOC`  is set, it means hedgedoc is local to docker. reference it directly by internal name (instead of localhost)

* [tests] added view tests for team, user + including regression test for #77

* making sure fix for #77 passes

* added extra test for team registration

* [ci] initial ghactions for testing

* [ci] added envvar

* [ci] use own container

* [ci] mising envar

* [ci] missing hedgedoc container

* moved helper functions into utils

* fixed bad merge fix

* complete project renaming -> ctfhub

* cleaned last reference to ctfpad

* And migration steps in readme

* fix test and ci

* formatting + linting

* proper use of `login_required`

* make sure all pages are authenticated

* update ci

* stuff

* removed unused `toggle_dark_mode` function

* linting

* [model] updated to django native types

* [model] using `models.TextChoices` for `Member.Country`

* replaced member.timezone  with django native + removed package `pytz`

* alter timezone db field

* aesthetic stuff

* fixed broken urls, and cosmetic changes

* [tests] test members cannot edit settings

* [tests] added test_member_cannot_edit_other_member_settings

* [tests] use http/403 for test_member_cannot_edit_other_member_settings instead of 404

* properly handle ctftime outage, decreased http get timeout setting to 10s

* skip ctftime tests if not responding

* [test] add `test_ctf_basic`

* [tests] added `test_member_basic`

* [models] add type hinting and killing bugs

* [models] sorted timezones

* deleted usless migration

* when exporting a hedgedoc note, do not follow redirect when authenticating

* [models] fixed notes export function

* part of #69 fixed all linting errors/warnings in ctfhub/helpers.poy
@hugsy
Copy link
Owner Author

hugsy commented Jul 4, 2023

Ok for now, continue for 0.2

@hugsy hugsy closed this as completed Jul 4, 2023
This was referenced Jul 5, 2023
Merged
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@hugsy hugsy

Labels
ci/cd documentation Improvements or additions to documentation help wanted Extra attention is needed priority:medium quality
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
1 participant
@hugsy