Beautify with automatic avatars #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanjelot
commented
Mar 17, 2021
| <td> | ||
| <a href="{% url 'ctfpad:users-detail' member.id %}">{{member.username}}</a> | ||
| </td> | ||
| <td style="text-align: center;"><img height="20px" width="25px" src="{{member.country_flag_url}}" alt="{{member.country}}" class="rounded-circle"></td> | ||
| <td style="text-align: center;"><img height="25px" width="25px" src="{{member.country_flag_url}}" alt="{{member.country}}" class="rounded-circle"></td> |
There was a problem hiding this comment.
the country flag image looked slightly oval before...
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now pulls the user's avatar from gravatar (which is based on the user's email md5 hash). If gravatar doesn't have a match then we pull a colored image from https://eu.ui-avatars.com/ containing the first 2 letters of the user's username. Also you can now mouse-over the avatar image to display the full username (thx to the
titleattribute in the<imgtag), so I removed the usernames from the podium since they looked a bit crooked anyway.On the
Player Rankingpage I made the left hand side more compact by removing the second h5 header and card-body div, so now there's only one h5 theAll Time Rankingh5, and the 2 tables are now inside the same card-body div. It works but tbh i have no idea what i'm doing when it comes to html/css.