Skip to content
This repository has been archived by the owner on Mar 15, 2020. It is now read-only.

Security: Mitigate HTTPoxy vulnerability #23

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Security: Mitigate HTTPoxy vulnerability #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/FileGetContents.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,10 +273,15 @@ protected function getMergedStreamContext($url)
{
$options = $this->options;

// Handle system proxy
if (!empty($_SERVER['HTTP_PROXY']) || !empty($_SERVER['http_proxy'])) {
// Some systems seem to rely on a lowercased version instead...
$proxy = parse_url(!empty($_SERVER['http_proxy']) ? $_SERVER['http_proxy'] : $_SERVER['HTTP_PROXY']);
// See CVE-2016-5385, due to (emulation of) header copying with PHP web SAPIs into HTTP_* variables,
// HTTP_PROXY can be set by an user to any value he wants by setting the Proxy header.
// Mitigate the vulnerability by only allowing CLI SAPIs to use HTTP(S)_PROXY environment variables.
if (PHP_SAPI === 'cli' || PHP_SAPI === 'phpdbg') {
// Handle system proxy
if (!empty($_SERVER['HTTP_PROXY']) || !empty($_SERVER['http_proxy'])) {
// Some systems seem to rely on a lowercased version instead...
$proxy = parse_url(!empty($_SERVER['http_proxy']) ? $_SERVER['http_proxy'] : $_SERVER['HTTP_PROXY']);
}
}

if (!empty($proxy)) {
Expand Down