Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

build: use different target dir for rust-analyzer to prevent thrashing with cargo #1460

Closed
wants to merge 1 commit into from

Conversation

MingweiSamuel
Copy link
Member

@MingweiSamuel MingweiSamuel commented Sep 23, 2024

Might only be a problem on windows?

Edit: seems to only be windows

@MingweiSamuel
Copy link
Member Author

MingweiSamuel commented Sep 23, 2024

Hmm, this might use up more disk space for @jhellerstein
Seems to use under 5gb for the extra target dir, out of ~50gb..

@shadaj
Copy link
Member

shadaj commented Sep 23, 2024

Wouldn't disabling the python feature be sufficient to prevent thrashing?

@MingweiSamuel
Copy link
Member Author

Not on my windows machine, both builds still invalidated each other

@shadaj
Copy link
Member

shadaj commented Sep 23, 2024

Maybe we should inspect all our build.rs, similar issues were happening in BLAKE3-team/BLAKE3#413

@MingweiSamuel MingweiSamuel marked this pull request as draft October 16, 2024 23:12
@MingweiSamuel MingweiSamuel removed the request for review from shadaj October 16, 2024 23:19
@MingweiSamuel
Copy link
Member Author

MingweiSamuel commented Oct 23, 2024

Just changed it on my user vscode settings.json on my windows machine.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants