fix: missing xhr-sync-worker.js
in jsdom
#121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Our library uses
jsdom
for DOM operations in Node.js environments. During the bundling process with tsup/esbuild, the modulexhr-sync-worker.js
fromjsdom
was not being correctly resolved, leading to a runtime error.Resolution
We have set
skipNodeModulesBundle
totrue
in our tsup configuration. This change instructs tsup/esbuild not to bundle thenode_modules
dependencies. As a result, Node.js handles the resolution and loading of modules at runtime, including the complex loading mechanisms used byjsdom
.Impact
This fix requires
jsdom
(and any other external module we use) to be installed in the user's project (we already recommend this), as our library now depends on these modules being present at runtime. This approach ensures that all dynamically loaded resources and complex module structures injsdom
are handled correctly by Node.js, preventing similar issues.Closes EX-975