Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make sure locals_max_{length,string} work as expected in case they are None #675

Merged
merged 3 commits into from
Jan 4, 2025
Merged

Make sure locals_max_{length,string} work as expected in case they are None #675

merged 3 commits into from
Jan 4, 2025

Conversation

Sh4pe
Copy link
Contributor

@Sh4pe Sh4pe commented Nov 13, 2024

This PR fixes the case where truncation or abbreviation in ExceptionDictTransformer is disabled using locals_max_length or locals_max_string.

Closes #672.

@Sh4pe Sh4pe force-pushed the fix/exception-dict-transformer-type-error branch from d124c51 to cab20c7 Compare November 13, 2024 23:16
@Sh4pe
Copy link
Contributor Author

Sh4pe commented Nov 13, 2024

Uhm, what about the pre-commit check? What is wrong there?

@Sh4pe Sh4pe force-pushed the fix/exception-dict-transformer-type-error branch from cab20c7 to d86f1c3 Compare December 3, 2024 20:45
@Sh4pe Sh4pe force-pushed the fix/exception-dict-transformer-type-error branch from d86f1c3 to 79297cf Compare December 3, 2024 20:47
hynek
hynek reviewed Jan 4, 2025
View reviewed changes
tests/test_tracebacks.py Outdated Show resolved Hide resolved
@hynek hynek merged commit 6f822dc into hynek:main Jan 4, 2025
19 checks passed
@hynek
Copy link
Owner

hynek commented Jan 4, 2025

thanks!

hynek added a commit that referenced this pull request Jan 4, 2025
@hynek
Add changelog for #675
3ba1c2e
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hynek hynek hynek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Sh4pe @hynek