This repository has been archived by the owner on Dec 26, 2024. It is now read-only.
Fab/docs #140
Closed
Fab/docs #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before: the gap between the buttons are not the same across the environment after 1. change the unit for the gap. % => px 2. gap will be decided with the height of FAB view
1. const GAP => props gap 2. omit generic
1. add story for FAB button in doc project 2. add basic introduction doc for FAB
Juyeong-Byeon
force-pushed
the
FAB/docs
branch
from
5153505 to
d1fe7db
Compare
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
=======================================
Coverage 94.59% 94.59%
=======================================
Files 27 27
Lines 648 648
Branches 283 283
=======================================
Hits 613 613
Misses 34 34
Partials 1 1 |
|
I will open again in PR |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I wrote a document for FAB.
I explained the definition of FAB and interface.
Test Plan
none
Related Issues
Related Issues
Tests
none
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.yarn test:alland make sure nothing fails. You can runyarn test -uto update snapshots if needed.