Skip to content
This repository has been archived by the owner on Dec 26, 2024. It is now read-only.

Update documentation for [Checkbox] #90

Merged
merged 1 commit into from
Sep 1, 2021
Merged

Conversation

2unbini
Copy link
Contributor

@2unbini 2unbini commented Aug 31, 2021

Description

Add source codes of checkbox samples and edited 'Props' to fit with the checkbox interface.
Images below are some screenshots of the edited storybook.

One thing I ask for you is to check if the type of onPress is correct.
I referred to the interface, but I'm not that familiar to typescript so I'm afraid that I've wrote wrong thing 😅

checkbox_storybook1

checkbox_storybook2

Related Issues

#57

Tests

No test

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn test or yarn test -u if you need to update snapshot.
  • Run yarn lint
  • I am willing to follow-up on review comments in a timely manner.

@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #90 (275f855) into master (b1049e7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   95.46%   95.46%           
=======================================
  Files          21       21           
  Lines         551      551           
  Branches      242      242           
=======================================
  Hits          526      526           
  Misses         25       25           

@hyochan hyochan added the 📖 documentation Improvements or additions to documentation label Sep 1, 2021
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well organized~! Looks great overall!

@hyochan
Copy link
Owner

hyochan commented Sep 1, 2021

@2unbini

For your question, currently it is onPress but I think we should change this props to onCheck and deprecate the onPress. Good point!

Also, next time you can try to make a commit message with a capital letter on the first word.

More about commit message is here.

@hyochan hyochan merged commit b59d562 into hyochan:master Sep 1, 2021
@2unbini
Copy link
Contributor Author

2unbini commented Sep 1, 2021

Oh I missed that part! Thank you for letting me know :)

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
📖 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants