Skip to content

malformed authority error with HTTP2 and gRPC #525

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
arthurlm opened this issue Mar 18, 2021 · 5 comments
Closed

malformed authority error with HTTP2 and gRPC #525

arthurlm opened this issue Mar 18, 2021 · 5 comments

Comments

@arthurlm
Copy link

arthurlm commented Mar 18, 2021

I am running h2 as a service in k8s to process gRPC requests.

Some clients of my service (envoy HTTP proxy) got error responses du to invalid authority field:

[2021-03-18T10:54:07Z DEBUG h2::server] malformed headers: malformed authority (b"extension/k8s-namespace-arthurlm-test/auth-server"): invalid uri character 

I do not have any ability to change envoy behavior: it need to use HTTP2 + TLS + cannot change request headers and payload.
I agree this authority is a little bit unexpected...

Should we make this kind of Authority allowed ?
Is there any way to allow h2 processing the request even if Authority::parse failed ?

@arthurlm arthurlm changed the title malformed authority error with HTTP2 malformed authority error with HTTP2 and gRPC Mar 18, 2021
@nox
Copy link
Contributor

nox commented May 4, 2021

Did you file an issue against the envoy HTTP proxy so they don't emit malformed authorities?

@nox
Copy link
Contributor

nox commented May 4, 2021

Duplicate of #442

@nox nox closed this as completed May 4, 2021
@nox nox marked this as a duplicate of #442 May 4, 2021
@arthurlm
Copy link
Author

arthurlm commented May 4, 2021

Unfortunately no 😞.

I have fork h2 and just show a log warn if authority field parsing fail.
See diff: master...arthurlm:master

I would be happy to merge this change in h2 but I do not know if this policy is the expected one by h2.

@nox
Copy link
Contributor

nox commented May 4, 2021

I am not sure what you mean by "unfortunately no". Isn't Envoy a FOSS project? Personally I don't think a patch to allow completely malformed authorities should be accepted.

@nox
Copy link
Contributor

nox commented May 4, 2021

Let's move this discussion to #442 please, as it is the same issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants