Add into_inner to AddrStream
#1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbarsky
reviewed
Feb 11, 2019
src/server/tcp.rs
Outdated
| @@ -219,6 +219,12 @@ mod addr_stream { | |||
| pub fn remote_addr(&self) -> SocketAddr { | |||
| self.remote_addr | |||
| } | |||
|
|
|||
| /// Consumes the AddrStream and return the underlying IO object | |||
There was a problem hiding this comment.
Copy editing nit: ”Consumes the AddrStream and returns the underlying IO object“
|
I think these changes are good! I think it'll require @seanmonstar's sign-off, but I'm not opposed to this. |
It consumes the `AddrStream` and returns the underlying TcpStream.
luben
force-pushed
the
addrstream-into-inner
branch
from
c5b208d to
35e0715
Compare
|
Thanks David, corrected it. |
|
I'm not opposed, but while we wait for CI, I'm curious to hear what use case you have that needed this :D |
|
I wanted to to an "upgrade" and get hands on the raw fd. Then redirect my stderr there. Obviously I needed some other logging around, including the remote address. I tried to do it with the low-level server::conn API but I couldn't get my head around how to do the upgrades. |
|
Makes sense, thanks! |
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It consumes the
AddrStreamand returns the underlying TcpStream.