Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(client): add resolve timeout to HttpConnector #1987

Closed
wants to merge 1 commit into from
Closed

feat(client): add resolve timeout to HttpConnector #1987

wants to merge 1 commit into from

Conversation

chewi
Copy link
Contributor

@chewi chewi commented Oct 21, 2019

The recently-added connect timeout does not cover resolving hostnames, which
could also stall on an OS-level timeout if there are issues reaching the DNS
server.

As mentioned in #1972.

The recently-added connect timeout does not cover resolving hostnames, which
could also stall on an OS-level timeout if there are issues reaching the DNS
server.
@chewi
Copy link
Contributor Author

chewi commented Oct 24, 2019

Ouch, serious rebase needed! I've done most of it but the pin stuff has me stumped. I'll try a bit longer.

@seanmonstar
Copy link
Member

Sorry for missing this! Though this reminds me, once Resolve is just a Service (#1903), a user could set a timeout on it individually:

use ServiceExt;

let resolver = GaiResolver::new().timeout(some_dur);
let connector = HttpConnector::with_resolver(resolver);

@chewi
Copy link
Contributor Author

chewi commented Oct 24, 2019 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants