feat(router): Add RoutesBuilder constructor #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Aug 6, 2024
tonic/src/service/router.rs
Outdated
| @@ -27,6 +27,11 @@ pub struct RoutesBuilder { | |||
| } | |||
|
|
|||
| impl RoutesBuilder { | |||
| /// Create a new empty builder. | |||
| pub fn empty() -> Self { | |||
There was a problem hiding this comment.
I don't see much value in this, and it's definitely not necessary for the builder() method.
There was a problem hiding this comment.
In terms of whether this is necessary for a Routes::builder method, it is not, but it is there to provide a constructor that indicates that intention, and is not provided for implementing a Routes::builder method.
There was a problem hiding this comment.
Removed it as the preferred style for creating builder is Routes::builder.
tottoto
force-pushed
the
add-routesbuilder-constructor
branch
from
0939a2a to
acc711b
Compare
djc
approved these changes
Aug 6, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
RoutesBuilderconstructor.