Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Docker build on local machines #1305

Closed

Conversation

sapiderman
Copy link
Contributor

Monika Pull Request (PR)

What feature/issue does this PR add

  1. Fixes make docker when command issued
  2. Fixes docker build configuration

How did you implement / how did you fix it

  1. Modify the builder base image to use non-alpine

How to test

  1. issue make docker
  2. or issue docker build -f Dockerfile .

Expect the build to be completed without error and a image is created
3. Check docker images to check created image.

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.56%. Comparing base (6a29470) to head (b657312).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1305      +/-   ##
==========================================
+ Coverage   62.51%   63.56%   +1.04%     
==========================================
  Files         112      109       -3     
  Lines        3391     3417      +26     
  Branches      591      583       -8     
==========================================
+ Hits         2120     2172      +52     
+ Misses       1079     1059      -20     
+ Partials      192      186       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sapiderman
Copy link
Contributor Author

This is duplicate to #1304.. will probably close this.

@sapiderman sapiderman closed this Jul 2, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant