Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add new Sonic tokens, some SVM tooling drive-bys #5334

Merged
merged 22 commits into from
Feb 18, 2025

Conversation

tkporter
Copy link
Collaborator

@tkporter tkporter commented Jan 29, 2025

Description

Drive-bys for the SVM tooling:

  • make sure that metadata for an SVM synthetic matches some basic expectations, e.g.
    • points to a legit machine readable URL (we had an issue here once)
    • image is a valid URL that's queryable
    • symbol / name match the token config (we had an issue here once)
  • No longer require explicitly specifying if a collateral token is SPL Token or SPL Token 2022. We imply this instead by looking at the owner of the collateral mint. Removes this from all previous configs

And adds the following tokens between Solana and Sonic: sSOL, USDStar, USDC, USDT, SONIC

Drive-by changes

Related issues

Backward compatibility

Testing

Copy link

changeset-bot bot commented Jan 29, 2025

⚠️ No Changeset found

Latest commit: aab83ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (4ddbd60) to head (aab83ef).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5334   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

Copy link
Contributor

@paulbalaji paulbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but would also appreciate a second review from @daniel-savu on the rust improvements

### Description

- Deploys the CDX token

### Drive-by changes

<!--
Are there any minor or drive-by changes also included?
-->

### Related issues

<!--
- Fixes #[issue number here]
-->

### Backward compatibility

<!--
Are these changes backward compatible? Are there any infrastructure
implications, e.g. changes that would prohibit deploying older commits
using this infra tooling?

Yes/No
-->

### Testing

<!--
What kind of testing have these changes undergone?

None/Manual/Unit Tests
-->
@tkporter tkporter added this pull request to the merge queue Feb 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2025
@tkporter tkporter enabled auto-merge February 18, 2025 11:50
@tkporter tkporter added this pull request to the merge queue Feb 18, 2025
Merged via the queue into main with commit 1f559c3 Feb 18, 2025
50 checks passed
@tkporter tkporter deleted the trevor/sonic-tokens branch February 18, 2025 12:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants