feat: github authenticated registry #506
Open
+182
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 79559ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nambrot
reviewed
Jan 22, 2025
nambrot
approved these changes
Jan 30, 2025
Mo-Hussain
reviewed
Jan 31, 2025
paulbalaji
approved these changes
Feb 7, 2025
| const response = await fetch(url, { | ||
| headers: useToken | ||
| ? { ...this.baseApiHeaders, Authorization: `Bearer ${this.authToken}` } | ||
| : undefined, |
There was a problem hiding this comment.
Why undefined and not this.baseApiHeaders?
| @@ -190,9 +197,9 @@ export class GithubRegistry extends BaseRegistry implements IRegistry { | |||
|
|
|||
| public async getApiRateLimit(): Promise<GithubRateResponse['resources']['core']> { | |||
| const response = await fetch(`${GITHUB_API_URL}/rate_limit`, { | |||
There was a problem hiding this comment.
Could not we use this.fetch and handle headers just once there?
mshojaei-txfusion
approved these changes
Feb 12, 2025
mshojaei-txfusion
suggested changes
Feb 12, 2025
| }); | ||
|
|
||
| it('should fail fetching chains with invalid authentication token', async () => { | ||
| expect(invalidTokenGithubRegistry.getChains()).to.eventually.be.rejected; |
There was a problem hiding this comment.
Suggested change
| expect(invalidTokenGithubRegistry.getChains()).to.eventually.be.rejected; | |
| return expect(invalidTokenGithubRegistry.getChains()).to.eventually.be.rejected; |
| }); | ||
|
|
||
| it('should fetch chains with authenticated token', async () => { | ||
| expect(invalidTokenGithubRegistry.getChains()).to.eventually.be.fulfilled; |
There was a problem hiding this comment.
Suggested change
| expect(invalidTokenGithubRegistry.getChains()).to.eventually.be.fulfilled; | |
| return expect(authenticatedGithubRegistry.getChains()) | |
| .to.eventually.be.fulfilled; |
|
Created #610 to main, and mkykadir#1 to @mkykadir repo. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Utilize
authTokenin GithubRegistry for authenticated Github requestsBackward compatibility
Yes
works as usual when no auth token is configured
Testing
New unit tests
Authenticated GithubRegistry