Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

revert: "feat: Add gitleaks to husky precommit" #582

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

paulbalaji
Copy link
Contributor

Reverts #578

because it's causing issues when importing in docs

https://yarnpkg.com/advanced/lifecycle-scripts#postinstall

Postinstall scripts should be avoided at all cost, as they make installs slower and riskier. Many users will refuse to install dependencies that have postinstall scripts. Additionally, since the output isn't shown out of the box, using them to print a message to the user will not work as you expect.

Copy link

changeset-bot bot commented Feb 13, 2025

🦋 Changeset detected

Latest commit: f7e00d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hyperlane-xyz/registry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paulbalaji paulbalaji requested review from yorhodes and ltyu February 13, 2025 16:50
@paulbalaji paulbalaji enabled auto-merge February 13, 2025 16:50
@paulbalaji paulbalaji disabled auto-merge February 13, 2025 16:53
@paulbalaji paulbalaji added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 2575aa5 Feb 13, 2025
6 checks passed
@paulbalaji paulbalaji deleted the revert-578-ltyu/add-gitleaks branch February 13, 2025 16:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants