This repository has been archived by the owner on Mar 30, 2018. It is now read-only.
Add make checks to PR template. Resolves #1905 #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi srderson, Thanks for submitting this pull request! I can confirm that the DCO1.1 sign-off has been included. It is okay to process this pull request. dco-bot |
| <!-- To uncheck box, add a space: [ ] --> | ||
| <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> | ||
| - [] I have added a [Signed-off-by](https://github.com/hyperledger/fabric/blob/master/CONTRIBUTING.md#legal-stuff). | ||
| - [] I have added documentation to cover my changes or this change requires no new documentation. |
There was a problem hiding this comment.
Just to check: does the following suggestion make this clearer or worse (to a native English speaker) ?
I have either added documentation to cover my changes or this change requires no new documentation.
Otherwise, sorry in advance for my broken English ;-)
|
I like the phrasing that @JonathanLevi suggested @srderson otherwise LGTM |
|
@JonathanLevi @christo4ferris Thanks for the feedback. I have updated the PR template with the suggested language. |
|
LGTM thanks! |
|
LGTM |
4 tasks
lhaskins
pushed a commit
to lhaskins/fabric-archive
that referenced
this pull request
Oct 14, 2016
…5/add_make_checks_to_pr_template Add make checks to PR template. Resolves hyperledger-archives#1905
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An updated pull request template that discusses
make checksMotivation and Context
Fixes #1905
This change was discussed with @ghaskins and @rameshthoomu. Please review this proposal. I have remove
go vetandgoimportsfrom the checklist and instead discuss howmake checkswill be run in CI and how it can be run locally.How Has This Been Tested?
No new tests required and this is only a change to the PR template.
Checklist:
Signed-off-by: Sheehan Anderson sheehan@us.ibm.com