-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ci(github): add dependency version consistency custom-check #3612
Comments
Primary Changes --------------- 1. Added a new custom check which checks if there are any inconsistency with the dependency version, which is already being used with an exsisting package. Changes needed to incorporate 1) ------------------------------- 2. Added a new dependency in the root package.json 3. Added a new npm script in the root package.json 4. Updated the lock file for the dependency inclusion Fixes hyperledger-cacti#3612 Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
Primary Changes --------------- 1. Added a new custom check which checks if there are any inconsistency with the dependency version, which is already being used with an exsisting package. Changes needed to incorporate 1) ------------------------------- 2. Added a new dependency in the root package.json 3. Added a new npm script in the root package.json 4. Updated the lock file for the dependency inclusion Fixes hyperledger-cacti#3612 Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
Primary Changes --------------- 1. Added a new custom check which checks if there are any inconsistency with the dependency version, which is already being used with an exsisting package. Changes needed to incorporate 1) ------------------------------- 2. Added a new dependency in the root package.json 3. Added a new npm script in the root package.json 4. Updated the lock file for the dependency inclusion Fixes hyperledger-cacti#3612 Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
Primary Changes --------------- 1. Added a new custom check which checks if there are any inconsistency with the dependency version, which is already being used with an exsisting package. Changes needed to incorporate 1) ------------------------------- 2. Added a new dependency in the root package.json 3. Added a new npm script in the root package.json 4. Updated the lock file for the dependency inclusion Fixes hyperledger-cacti#3612 Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
Primary Changes --------------- 1. Added a new custom check which checks if there are any inconsistency with the dependency version, which is already being used with an exsisting package. Changes needed to incorporate 1) ------------------------------- 2. Added a new dependency in the root package.json 3. Added a new npm script in the root package.json 4. Updated the lock file for the dependency inclusion Fixes hyperledger-cacti#3612 Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
Primary Changes --------------- 1. Added a new custom check which checks if there are any inconsistency with the dependency version, which is already being used with an exsisting package. Changes needed to incorporate 1) ------------------------------- 2. Added a new dependency in the root package.json 3. Added a new npm script in the root package.json 4. Updated the lock file for the dependency inclusion Fixes hyperledger-cacti#3612 Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
To incorporate fixes for this task (after the script is pushed to the code), I am creating tasks to approach this in a phased approach. Each of the phases will include a maximum of 5 packages (with the tougher ones in my opinion having less packages) |
Primary Changes --------------- 1. Added a new custom check which checks if there are any inconsistency with the dependency version, which is already being used with an exsisting package. Changes needed to incorporate 1) ------------------------------- 2. Added a new dependency in the root package.json 3. Added a new npm script in the root package.json 4. Updated the lock file for the dependency inclusion Fixes hyperledger-cacti#3612 Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
Primary Changes --------------- 1. Added a new custom check which checks if there are any inconsistency with the dependency version, which is already being used with an exsisting package. Changes needed to incorporate 1) ------------------------------- 2. Added a new dependency in the root package.json 3. Added a new npm script in the root package.json 4. Updated the lock file for the dependency inclusion Fixes hyperledger-cacti#3612 Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
@jagpreetsinghsasan Nice! Thank you very much! |
Primary Changes --------------- 1. Added a new custom check which checks if there are any inconsistency with the dependency version, which is already being used with an exsisting package. Changes needed to incorporate 1) ------------------------------- 2. Added a new dependency in the root package.json 3. Added a new npm script in the root package.json 4. Updated the lock file for the dependency inclusion Fixes hyperledger-cacti#3612 Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
Primary Changes --------------- 1. Added a new custom check which checks if there are any inconsistency with the dependency version, which is already being used with an exsisting package. Changes needed to incorporate 1) ------------------------------- 2. Added a new dependency in the root package.json 3. Added a new npm script in the root package.json 4. Updated the lock file for the dependency inclusion Fixes hyperledger-cacti#3612 Signed-off-by: jagpreetsinghsasan <jagpreetsinghsasan@accenture.com>
Problem Statement
In our monorepository code reviewers have to manually keep track of contributors
using the correct version string for packages and their dependencies.
Types of issues that arise (not a complete list)
core
package declares that it depends on thecommon@1.0.0
package or for another exmaple, thecore-api
package declares that it depends on the common@2.0.0-rc.1 package. Both of these cases are wrong becaus they should only be using the current latest relesae version which in this case is2.0.0
express
or@grpc-js/grpc
which causes compilation issues across the board.Acceptance Criteria
https://github.com/bmish/check-dependency-version-consistency
yarn custom-check
and any of the problems are present from theTypes of issues that arise (not a complete list)
section then it needs to fail.tools:check-dependency-version-consistency
The text was updated successfully, but these errors were encountered: