Review fixes

Signed-off-by: Dmitry Murzin <diralik@yandex.ru>

crates/iroha_data_model/src/transaction.rs

@@ -183,7 +183,7 @@ mod model {
 
 impl<A: Instruction> FromIterator<A> for Executable {
     fn from_iter<T: IntoIterator<Item = A>>(iter: T) -> Self {
-        Self::Instructions(iter.into_iter().map(Into::into).collect::<Vec<_>>().into())
+        Self::Instructions(iter.into_iter().map(Into::into).collect())
     }
 }
 

crates/iroha_data_model/src/visit.rs

@@ -145,7 +145,7 @@ pub fn visit_transaction<V: Visit + ?Sized>(
     match transaction.instructions() {
         Executable::Wasm(wasm) => visitor.visit_wasm(authority, wasm),
         Executable::Instructions(instructions) => {
-            for isi in instructions.as_ref() {
+            for isi in instructions {
                 visitor.visit_instruction(authority, isi);
             }
         }

crates/iroha_executor/src/default.rs

@@ -63,7 +63,7 @@ pub fn visit_transaction<V: Validate + Visit + ?Sized>(
     match transaction.instructions() {
         Executable::Wasm(wasm) => executor.visit_wasm(authority, wasm),
         Executable::Instructions(instructions) => {
-            for isi in instructions.as_ref() {
+            for isi in instructions {
                 if executor.verdict().is_ok() {
                     executor.visit_instruction(authority, isi);
                 }

crates/iroha_primitives/src/const_vec.rs

@@ -92,6 +92,16 @@ impl<T: IntoSchema> IntoSchema for ConstVec<T> {
     }
 }
 
+impl<'a, T> IntoIterator for &'a ConstVec<T> {
+    type Item = &'a T;
+
+    type IntoIter = <&'a [T] as IntoIterator>::IntoIter;
+
+    fn into_iter(self) -> Self::IntoIter {
+        self.0.into_iter()
+    }
+}
+
 impl<T> IntoIterator for ConstVec<T> {
     type Item = T;
 
@@ -102,6 +112,13 @@ impl<T> IntoIterator for ConstVec<T> {
     }
 }
 
+impl<T> FromIterator<T> for ConstVec<T> {
+    fn from_iter<I: IntoIterator<Item = T>>(iter: I) -> Self {
+        let vec: Vec<T> = iter.into_iter().collect();
+        Self::new(vec)
+    }
+}
+
 /// Trait to extend `[T]` with a method to convert it to `ConstVec<T>` by analogy with `[T]::to_vec()`.
 pub trait ToConstVec {
     /// The type of the items in the slice.