-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[fix] #3451: Fix docker build on M1 #3747
[fix] #3451: Fix docker build on M1 #3747
Conversation
Pull Request Test Coverage Report for Build 5695117197
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I could not approve. Unfortunately, I could not check how it works on my machine. There are Docker errors, which I don't want to debug, because too much effort for too less output.
Works on my M2 machine. |
25aa2d4
to
da8e0ca
Compare
Which errors specifically? It would need to be verified by QA anyways, but I want to make it as robust as possible still. And I do agree debugging it is really frustrating. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Takes forever to build on my M1. Complains a lot about jemalloc
. So same as before.
I wasn't able to wait until it builds, but overall looks fine.
Signed-off-by: Ilia Churin <churin.ilya@gmail.com>
7820a0f
to
cacafbb
Compare
Description
The docker build on M1 was failing because of lacking
platform
tag at first, and then because of some missing links towasm-opt
's musl binaries.Linked issue
Closes #3451.
Benefits
Finally local docker launching as expected on M1 machines, abysmal build times notwithstanding.
Checklist
CONTRIBUTING.md