-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: unnest wasm samples from client
, exclude it from workspace
#4863
fix: unnest wasm samples from client
, exclude it from workspace
#4863
Conversation
89ddd9e
to
4482538
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the change is ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that our default executor is a terribly useful example, but having all crates that compile into on-chain wasm in one place does sound logical.
We might also want to make it more apparent which of the wasm examples are smart contracts, triggers or executors. Some naming conventions are trying to appear (executors are prefixed with _executor
, triggers have _trigger
somewhere in the name, smart contracts do not have those), but multisig
and multisig_register
kind of break this convention currently.
4482538
to
9600c8f
Compare
9600c8f
to
4ee3428
Compare
4ee3428
to
75c979a
Compare
75c979a
to
fe62cb2
Compare
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
fe62cb2
to
28380a7
Compare
Description
smartcontracts
out ofclient/tests/integration
smartcontracts
towasm_samples
executor_custom_data_model
version inclient
wasm_samples
from the workspacedefault_executor
towasm_samples
Benefits
fixes the error with
cargo install
:package `.../client/tests/integration/smartcontracts/executor_custom_data_model/Cargo.toml` is a member of the wrong workspace
wasm samples (executors, smartcontracts and triggers) are more discoverable
Dependabot updates target all wasm samples instead of just the default executor
Checklist
CONTRIBUTING.md