Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: validate block sync messages #4965

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Aug 12, 2024

Description

  • validate received block sync messages
  • optimize FindBlockHeaderByHash
  • add start to all_blocks

Linked issue

Closes #{issue_number}

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@mversic mversic force-pushed the block_sync_fix branch 3 times, most recently from ede0748 to 18445e9 Compare August 14, 2024 15:32
@mversic mversic enabled auto-merge (squash) August 14, 2024 15:32
dima74
dima74 previously approved these changes Aug 15, 2024
@mversic mversic force-pushed the block_sync_fix branch 2 times, most recently from 3fb5355 to b0ef773 Compare August 19, 2024 09:38
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@nxsaken nxsaken disabled auto-merge August 21, 2024 08:47
@nxsaken nxsaken merged commit d2b70d3 into hyperledger-iroha:main Aug 21, 2024
10 of 12 checks passed
mversic added a commit that referenced this pull request Aug 30, 2024
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants