perf: Make PublicKey decoding lazy inside WASM
#5048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima74
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
0x009922 and
DCNick3
as code owners
dima74
force-pushed
the
diralik/wasm-lazy-decoding-PublicKey
branch
from
a2e9088 to
66b7494
Compare
DCNick3
reviewed
Sep 9, 2024
dima74
force-pushed
the
diralik/wasm-lazy-decoding-PublicKey
branch
from
66b7494 to
2c799e1
Compare
DCNick3
previously approved these changes
Sep 10, 2024
nxsaken
reviewed
Sep 11, 2024
dima74
force-pushed
the
diralik/wasm-lazy-decoding-PublicKey
branch
from
2c799e1 to
b81435c
Compare
Erigara
previously approved these changes
Sep 12, 2024
DCNick3
previously approved these changes
Sep 12, 2024
dima74
force-pushed
the
diralik/wasm-lazy-decoding-PublicKey
branch
2 times, most recently
from
7e06caa to
b9b4757
Compare
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
nxsaken
force-pushed
the
diralik/wasm-lazy-decoding-PublicKey
branch
from
b9b4757 to
ad6fb9d
Compare
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
|
Looks like this PR would fail I2::Dev::Wasm workflow. Please review latest commit with the fix |
DCNick3
approved these changes
Sep 12, 2024
Erigara
approved these changes
Sep 13, 2024
5 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #5038
Solution
Make
PublicKeydecoding lazy inside WASM, sincePublicKeyin WASM is used mostly for comparison operations (==), and comparison can be performed without decoding (see #5038 for details). This givess approximatelly 400tps increase for single peer (from ~2450 to ~2850).Review notes (optional)
Checklist
CONTRIBUTING.md.