fix: Fix iroha_genesis compilation without transparent_api feature
#5056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima74
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
0x009922 and
DCNick3
as code owners
mversic
reviewed
Sep 10, 2024
mversic
previously approved these changes
Sep 11, 2024
0x009922
previously approved these changes
Sep 11, 2024
nxsaken
previously approved these changes
Sep 11, 2024
nxsaken
force-pushed
the
diralik/fix-iroha-genesis-transparent-api
branch
from
166649c to
1accc6b
Compare
dima74
force-pushed
the
diralik/fix-iroha-genesis-transparent-api
branch
from
1accc6b to
e3c79b7
Compare
nxsaken
approved these changes
Sep 11, 2024
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
mversic
force-pushed
the
diralik/fix-iroha-genesis-transparent-api
branch
from
e3c79b7 to
9f53082
Compare
mversic
approved these changes
Sep 12, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fixes #5049
Solution
apply_parameterfunction to thedata_modelreported_length_should_be_accurateused port 11_170 which conflicts withregister_offline_peerjson_and_scale_statuses_equalityused port 11_200 which conflicts withrestarted_peer_should_have_the_same_asset_amountChecklist
CONTRIBUTING.md.