Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(ffi): Add implementation of Niche for Option<Box<R>> #5094

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Sep 23, 2024

Context

  • Describe the objective or issue this PR addresses, as well as the impact of the change.
  • Try to keep the description accessible to newcomers.
  • If you're resolving a specific issue, add "Fixes #issue_number" or "Closes #issue_number".

Solution

  • Describe the approach taken to achieve the objective / resolve the issue.

Migration Guide (optional)

  • If this PR contains a breaking change relative to the main branch, provide an instruction on how affected parties might need to adapt to the change.

Review notes (optional)

  • For complex PRs, try to provide some information on how to approach the review more effectively.
  • For example, is there a natural order in which the affected files should be reviewed?

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@mversic mversic merged commit 8580c57 into hyperledger-iroha:main Sep 23, 2024
15 of 16 checks passed
@mversic mversic deleted the fix_ffi_option_box branch September 23, 2024 07:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants