refactor: remove module-based api from client #5184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoyako
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
0x009922,
DCNick3 and
dima74
as code owners
aoyako
changed the title
aoyako
force-pushed
the
revise_client_query_api
branch
3 times, most recently
from
eebcbaf to
7629d73
Compare
nxsaken
reviewed
Oct 23, 2024
nxsaken
previously approved these changes
Oct 23, 2024
mversic
reviewed
Oct 23, 2024
crates/iroha_data_model_derive/tests/ui_fail/has_origin_multiple_attributes.stderr
Outdated
Show resolved
Hide resolved
nxsaken
approved these changes
Oct 24, 2024
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
Signed-off-by: Lohachov Mykhailo <lohachov@soramitsu.co.jp>
mversic
force-pushed
the
revise_client_query_api
branch
from
2367c41 to
323d901
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4892
Context: #4833 (comment)
Solution
This PR removes helper query functions (such as
asset::all_definitions()) in the client. Instead, an API similar to the one in smartcontracts is preferred (FindAllAssetDefinitions::new()).Checklist
CONTRIBUTING.md.