Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: Protect BasicAuth::password from being printed #5195

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix: Protect BasicAuth::password from being printed #5195

merged 1 commit into from
Oct 28, 2024
+42 −6

Conversation

dima74
Copy link
Contributor

@dima74 dima74 commented Oct 25, 2024

Context

Fixes #5182

Checklist

  • I've read CONTRIBUTING.md.
  • (optional) I've written unit tests for the code changes.
  • All review comments have been resolved.
  • All CI checks pass.

@dima74
fix: Protect BasicAuth::password from being printed
9784704 
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
@dima74 dima74 self-assigned this Oct 25, 2024
@s8sato s8sato self-assigned this Oct 28, 2024
@mversic mversic merged commit d2846a3 into hyperledger-iroha:main Oct 28, 2024
11 of 13 checks passed
@dima74 dima74 deleted the diralik/protect-basicauth-password branch October 28, 2024 08:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mversic mversic mversic approved these changes

@s8sato s8sato s8sato approved these changes

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

Assignees

@dima74 dima74

@s8sato s8sato

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Protect BasicAuth::password from being printed
3 participants
@dima74 @mversic @s8sato