Purge data in explorer based on a parameter #341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhay Kishore <abhay.kishore@walmart.com>
| @@ -2,7 +2,8 @@ | |||
| "network-configs": { | |||
| "test-network": { | |||
| "name": "Test Network", | |||
| "profile": "./connection-profile/test-network.json" | |||
| "profile": "./connection-profile/test-network.json", | |||
| "blockCount": "5" | |||
There was a problem hiding this comment.
[nitpick]: update this to numerical value.
adityajoshi12
approved these changes
Feb 1, 2023
| @@ -86,6 +88,8 @@ export class SyncPlatform { | |||
| this.network_name = args[1]; | |||
| } | |||
|
|
|||
| this.blockCount = network_configs[this.network_id].blockCount; | |||
There was a problem hiding this comment.
blockCount needs to be defined in config.json in (app/platform/fabric/config.json)
| * @returns | ||
| * @memberof CRUDService | ||
| */ | ||
| async deleteBlock(network_name, channel_genesis_hash, blockCount) { |
There was a problem hiding this comment.
Ongoing we can add types also in the function args
|
Duplicate of #362 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abhay Kishore abhay.kishore@walmart.com
What this PR does / why we need it:
It will purge the old data present in explorer db based on the parameter
blockCount.blockCountproperty can be defined inconfig.json.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation, usage docs, etc.: