Code changes for Issue #404 SSL enable Sequelize #413
Conversation
|
|
||
| } | ||
|
|
||
|
|
||
| this.userModel = sequelize.define('users', attributes, options); |
There was a problem hiding this comment.
Please change the scope of 'sequelize' so that it can be accessed in the line 120.
There was a problem hiding this comment.
@zicaden Thanks for the update. Need to discuss about the SSL enable functionality. Can you please join the maintainers by-weekly call? If so, it would be greatly appreciated!
There was a problem hiding this comment.
Hello - Please share the details of the call
There was a problem hiding this comment.
@Udhayakumari - tagging you. Please let me know the details of the call. Also I found some new issues - the SSL configuration is better to be done using environment variables -
e.g. DATABASE_MTLS_ENABLED = true | false
If false - then we can avoid placing the certificate and key (key: | cert:)
We encountered issue while connecting with Azure Postgres Flexible Server where these parameters are causing issues. If you want I can provide you an updated code with these changes.
There was a problem hiding this comment.
@Udhayakumari - Hello I joined the meeting today but no one joined.
Wednesday, April 17th, 2024
2:00pm to 3:00pm
(UTC) Coordinated Universal Time
Repeats:
Every 2 weeks on Wednesday
Location:
https://zoom.us/my/hyperledger.community?pwd=STZQd0xMZU9xRVVOVnpQM3JNQ2dqZz09
Organizer:
Blockchain Explorer Maintainers
Description:
Blockchain Explorer - Hyperledger Labs project weekly contributors meeting.
Meeting ID: 403 498 3298
Passcode: 475869
https://zoom.us/j/4034983298?pwd=STZQd0xMZU9xRVVOVnpQM3JNQ2dqZz09
There was a problem hiding this comment.
@zicaden Yesterday call has been cancelled. Sorry for the inconvenience!
There was a problem hiding this comment.
@Udhayakumari - please confirm if this can be discussed in your next meeting scheduled on 4th Sep, 2024 at 7:30 PM IST? If not, kindly confirm the specific meeting date / time when you can be available.
There was a problem hiding this comment.
@Udhayakumari - I joined today but no one joined.
There was a problem hiding this comment.
@Udhayakumari - I believe the meetings have been updated. Could you please share me the next meeting details. The calendar link is no longer active.
@ArchanaArige - FYI - tagging you for help as @Udhayakumari is not responding
|
Updated code - kindly check |
|
Thanks @zicaden. Please squash the commits into one commit. |
Signed-off-by: zicaden <zicaden@yahoo.com> fix sequelize variable scope Signed-off-by: zicaden <zicaden@yahoo.com>
Completed! Kindly check |
What this PR does / why we need it: Issue #404
Which issue(s) this PR fixes: Issue #404
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation, usage docs, etc.: