Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds salt to the EIP712Domain. According to the EIP, a salt can be added to the domain:
I double checked the results with what I got back from an EIP712 demo together with metamask. I also verified it in remix.
Where should the reviewer start?
4 changes:
Why is it needed?
If you use a valid EIP712 json with a salt, you get a deserialisation exception (unknown field).
Since this is part of the EIP it should be implemented.