Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

#2121 - clear subscriptionForId map after websocket disconnects #2129

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

Shohou
Copy link
Contributor

@Shohou Shohou commented Dec 16, 2024

What does this PR do?

fixes #2121

Where should the reviewer start?

At WebSocketService.java

Why is it needed?

to fix #2121

Checklist

  • I've read the contribution guidelines.
  • I've added tests (if applicable).
  • I've added a changelog entry if necessary.

@NickSneo
Copy link
Contributor

@Shohou Can you please add DCO to all your commits.

@Shohou Shohou force-pushed the 2121_subscription_for_id branch from 1930f1c to 9e8d1b6 Compare December 17, 2024 06:41
… disconnects

Signed-off-by: Dmitry Shohov <shohou@gmail.com>
@Shohou Shohou force-pushed the 2121_subscription_for_id branch from 9e8d1b6 to ae3edeb Compare December 17, 2024 06:48
@Shohou
Copy link
Contributor Author

Shohou commented Dec 17, 2024

@NickSneo done

@gtebrean gtebrean merged commit 286b63d into hyperledger-web3j:main Dec 17, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebSocketService leaks subscriptions and requests after disconnect
3 participants