Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/use gnark-crypto for eip-196 precompiles #7262

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

garyschulte
Copy link
Contributor

@garyschulte garyschulte commented Jun 25, 2024

PR description

Use gnark-crypto from besu-native for ECC precompiles

  • eip-196
  • eip-197

This will get besu onto a supported and more performant ECC library, and should allow us to remove tech debt in besu-native.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@garyschulte garyschulte force-pushed the feature/use-gnark-for-ecc branch 7 times, most recently from 4ed3a3a to 1099630 Compare June 26, 2024 20:18
@macfarla
Copy link
Contributor

LGTM except there are 10 tests failing

GeneralStateReferenceTest_507 > execution(String, GeneralStateTestCaseEipSpec, boolean) > Name: idPrecomps-Berlin[5] FAILED
java.lang.RuntimeException at GeneralStateReferenceTest_507.java:39

@garyschulte garyschulte force-pushed the feature/use-gnark-for-ecc branch 2 times, most recently from 9980359 to 579c053 Compare July 1, 2024 21:07
@garyschulte garyschulte marked this pull request as draft July 12, 2024 20:08
@garyschulte garyschulte changed the title Feature/use gnark-crypto for ecc precompiles Feature/use gnark-crypto for eip-196 precompiles Jul 12, 2024
… match target dirs

Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
@garyschulte garyschulte marked this pull request as ready for review July 17, 2024 20:07
@garyschulte garyschulte merged commit 8eef2df into hyperledger:main Jul 17, 2024
40 checks passed
@garyschulte garyschulte deleted the feature/use-gnark-for-ecc branch July 17, 2024 20:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants