-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix protocol schedule for devnets #7429
Merged
macfarla
merged 14 commits into
hyperledger:main
from
daniellehrner:fix/issue-7413/fix_protocol_schedule_devnets
Aug 12, 2024
Merged
Fix protocol schedule for devnets #7429
macfarla
merged 14 commits into
hyperledger:main
from
daniellehrner:fix/issue-7413/fix_protocol_schedule_devnets
Aug 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hardfork in the genesis file Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
…k ids Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
…rt of the Shanghai spec. The previous checks for Cancun seem not to have worked and therefore didn't cause the tests to fail. Now that those checks work correctly the test were failing. Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
…been introduced in the Cancun spec, now they work correctly Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
…ED_FORK past Cancun Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
verified successful block production using kurtosis provided above.
|
macfarla
approved these changes
Aug 12, 2024
gconnect
pushed a commit
to gconnect/besu
that referenced
this pull request
Aug 26, 2024
* add `ProtocolSchedule::milestoneFor` to retrieve milestones for every hardfork in the genesis file * add `setMilestones` and `milestoneFor` to TransitionProtocolSchedule * refactored all checks for hardforks in the engine API to use hard fork ids * added tests to test that the engine API v2 endpoints return UNSUPPORTED_FORK past Cancun Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> --------- Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: gconnect <agatevureglory@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Introduces a hard fork id into the protocol schedule and keeps track of all the hardforks in the genesis file. This allows correct checks in the engine API if certain hardforks have already occured or not.
Fixed Issue(s)
fixes #7413
Testing
After running
./gradlew distDocker
the PR can be tested with the following Kurtosis config:To get the log output of the Besu instances in Kurtosis use:
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests