Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Plumb maxCode overriddes into EVM #7557

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Plumb maxCode overriddes into EVM #7557

merged 3 commits into from
Sep 2, 2024

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Sep 2, 2024

PR description

Restore lost functionality: the maxcodesize and maxinitcodesize should
be plumed into the operations and validation rules when set.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@shemnon
Plumb maxCode overriddes into EVM
bcd40b1 
Restore lost functionality: the maxcodesize and maxinitcodesize should
be plumed into the operations and validation rules when set.

Signed-off-by: Danno Ferrin <danno@numisight.com>
matthew1001
matthew1001 approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@matthew1001 matthew1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might be worth a changelog entry?

@shemnon
Plumb maxCode overriddes into EVM
5e85e80 
Restore lost functionality: the maxcodesize and maxinitcodesize should
be plumed into the operations and validation rules when set.

Signed-off-by: Danno Ferrin <danno@numisight.com>
@macfarla macfarla enabled auto-merge (squash) September 2, 2024 21:44
@macfarla macfarla merged commit 65240fd into hyperledger:main Sep 2, 2024
40 checks passed
@shemnon shemnon deleted the evm/maxcode-overrides branch September 2, 2024 22:25
@jflo jflo mentioned this pull request Oct 15, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@matthew1001 matthew1001 matthew1001 approved these changes

@macfarla macfarla macfarla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shemnon @macfarla @matthew1001