-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add ephemery network config #7563
Add ephemery network config #7563
Conversation
Signed-off-by: gconnect <agatevureglory@gmail.com>
Signed-off-by: gconnect <agatevureglory@gmail.com>
Signed-off-by: gconnect <agatevureglory@gmail.com>
Signed-off-by: gconnect <agatevureglory@gmail.com>
Signed-off-by: gconnect <agatevureglory@gmail.com>
…nt from test Signed-off-by: gconnect <agatevureglory@gmail.com>
@macfarla you can go over the requested changes here. |
besu/src/main/java/org/hyperledger/besu/cli/config/NetworkName.java
Outdated
Show resolved
Hide resolved
besu/src/main/java/org/hyperledger/besu/util/EphemeryGenesisFile.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Glory Agatevure <agatevureglory@gmail.com>
Signed-off-by: gconnect <agatevureglory@gmail.com>
Signed-off-by: gconnect <agatevureglory@gmail.com>
besu/src/main/java/org/hyperledger/besu/cli/config/NetworkName.java
Outdated
Show resolved
Hide resolved
besu/src/main/java/org/hyperledger/besu/util/EphemeryGenesisFile.java
Outdated
Show resolved
Hide resolved
besu/src/test/java/org/hyperledger/besu/util/EphemeryGenesisFileTest.java
Outdated
Show resolved
Hide resolved
besu/src/test/java/org/hyperledger/besu/util/EphemeryGenesisFileTest.java
Outdated
Show resolved
Hide resolved
besu/src/test/java/org/hyperledger/besu/util/EphemeryGenesisFileTest.java
Outdated
Show resolved
Hide resolved
besu/src/test/java/org/hyperledger/besu/util/EphemeryGenesisFileTest.java
Outdated
Show resolved
Hide resolved
besu/src/main/java/org/hyperledger/besu/util/EphemeryGenesisFile.java
Outdated
Show resolved
Hide resolved
…, remove unused code and setNetworkId Signed-off-by: gconnect <agatevureglory@gmail.com>
@macfarla all requested updates have been made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok think it is getting close! a few nits and suggestions on naming
besu/src/main/java/org/hyperledger/besu/cli/config/NetworkName.java
Outdated
Show resolved
Hide resolved
besu/src/main/java/org/hyperledger/besu/cli/config/NetworkName.java
Outdated
Show resolved
Hide resolved
besu/src/main/java/org/hyperledger/besu/util/EphemeryGenesisFile.java
Outdated
Show resolved
Hide resolved
besu/src/main/java/org/hyperledger/besu/util/EphemeryGenesisFile.java
Outdated
Show resolved
Hide resolved
besu/src/test/java/org/hyperledger/besu/util/EphemeryGenesisFileTest.java
Outdated
Show resolved
Hide resolved
besu/src/test/java/org/hyperledger/besu/util/EphemeryGenesisFileTest.java
Outdated
Show resolved
Hide resolved
besu/src/main/java/org/hyperledger/besu/util/EphemeryGenesisFile.java
Outdated
Show resolved
Hide resolved
besu/src/main/java/org/hyperledger/besu/util/EphemeryGenesisFile.java
Outdated
Show resolved
Hide resolved
Signed-off-by: gconnect <agatevureglory@gmail.com>
Signed-off-by: gconnect <agatevureglory@gmail.com>
@macfarla made the requested changes thanks for reviewing. |
besu/src/main/java/org/hyperledger/besu/util/EphemeryGenesisUpdater.java
Outdated
Show resolved
Hide resolved
besu/src/test/java/org/hyperledger/besu/util/EphemeryGenesisUpdaterTest.java
Outdated
Show resolved
Hide resolved
@macfarla I am done with all the requested changes please review when you have the time. @Gabriel-Trintinalia please also assist with reviewing when you have the time thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of final comments on the test class, otherwise LGTM
changelog has a conflict
besu/src/test/java/org/hyperledger/besu/util/EphemeryGenesisUpdaterTest.java
Outdated
Show resolved
Hide resolved
besu/src/test/java/org/hyperledger/besu/util/EphemeryGenesisUpdaterTest.java
Outdated
Show resolved
Hide resolved
besu/src/test/java/org/hyperledger/besu/util/EphemeryGenesisUpdaterTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic contribution, thanks so much. The only thing I would add (doesn't have to be in this PR, would be fine in a new one) is maybe some Ephemery specific logging when the network rolls over. Right now, the user will get:
2024-10-01 08:09:00.429-04:00 | main | ERROR | Besu | Failed to start Besu
picocli.CommandLine$ExecutionException: Supplied genesis block does not match chain data stored in /Users/jflo/src/besu/build/data.
Please specify a different data directory with --data-path, specify the original genesis file with --genesis-file or supply a testnet/mainnet option with --network.
It might be worth adding a line explaining that if Ephemery rolled over, they need to reset their data, and this is to be expected.
Signed-off-by: Glory Agatevure <agatevureglory@gmail.com>
@jflo thanks for this. Once this PR is merged the automatic database reset feature is what I will be working on next. That should fix the above issue. |
Signed-off-by: gconnect <agatevureglory@gmail.com>
@macfarla I have made the requested changes. |
Signed-off-by: gconnect <agatevureglory@gmail.com>
Head branch was pushed to by a user without write access
Signed-off-by: gconnect <agatevureglory@gmail.com>
Signed-off-by: Glory Agatevure <agatevureglory@gmail.com>
Signed-off-by: gconnect <agatevureglory@gmail.com>
@gconnect there's a failing test BesuCommandTest > ephemeryValuesAreUsed() FAILED |
Signed-off-by: gconnect <agatevureglory@gmail.com>
Thanks for your contribution on this @gconnect 🎉 |
Thanks for reviewing. |
* Add Ephemery genesis config file Signed-off-by: gconnect <agatevureglory@gmail.com> --------- Signed-off-by: gconnect <agatevureglory@gmail.com> Signed-off-by: Glory Agatevure <agatevureglory@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>Signed-off-by: Chulhee lee <leefehee@naver.com>
PR description
Fixed Issue(s)
This PR is in response to this issue 7404
@non-fungible-nelson please review when you have some time.
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests