Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replace dep on fftm+core with new firefly-common package #216

Merged
merged 3 commits into from
May 5, 2022

Conversation

peterbroadhurst
Copy link
Contributor

@peterbroadhurst peterbroadhurst commented May 5, 2022

We ended up pulling in a huge tree of dependencies by the definitions for the FFCAPI being FireFly Transaction Manager, which depends then on FireFly Core for types. Now everything has moved to FireFly Common, we have a much slimmer set of deps to pull in.

Also renamed ffc package to ffcapiconnector on feedback that ffc was too vague.

Depends on (go.mod pulls these in directly):

Also see:

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #216 (85bfc42) into main (a2b26d6) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   97.25%   97.28%   +0.02%     
==========================================
  Files          70       70              
  Lines        7539     7539              
==========================================
+ Hits         7332     7334       +2     
+ Misses        159      158       -1     
+ Partials       48       47       -1     
Impacted Files Coverage Δ
ethconnect/internal/ffc/get_gas_price.go
ethconnect/internal/ffc/send_transaction.go
ethconnect/internal/ffc/get_receipt.go
ethconnect/internal/ffc/server.go
ethconnect/internal/ffc/get_block_info.go
ethconnect/internal/ffc/exec_query.go
ethconnect/internal/ffc/create_block_listener.go
ethconnect/internal/ffc/prepare_transaction.go
ethconnect/internal/ffc/get_new_block_hashes.go
ethconnect/internal/ffc/error_mapping.go
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b26d6...85bfc42. Read the comment docs.

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst peterbroadhurst merged commit 42d3d0c into hyperledger:main May 5, 2022
@peterbroadhurst peterbroadhurst deleted the ffcommon branch May 5, 2022 21:23
Copy link

@JMP2590 JMP2590 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants