Two phase init was not passing smartContractGW to receipt store #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbroadhurst
requested review from
vdamle,
jimthematrix and
awrichar
as code owners
Codecov Report
@@ Coverage Diff @@
## main #228 +/- ##
=======================================
Coverage 96.95% 96.95%
=======================================
Files 70 70
Lines 7728 7729 +1
=======================================
+ Hits 7493 7494 +1
Misses 184 184
Partials 51 51
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…ning no WS receipts Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
peterbroadhurst
force-pushed
the
fix-init
branch
from
4b2666f to
70236dc
Compare
vdamle
approved these changes
Sep 1, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which meant no WS receipts were being delivered.
This was caused by new initialization order in #227
Found through e2e in FireFly under hyperledger/firefly#1033