Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add name/version if not specified #1432

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Add name/version if not specified #1432

merged 1 commit into from
Dec 13, 2023

Conversation

peterbroadhurst
Copy link
Contributor

In recent changes, the name/version of the FFI have become required, and this means that the API for /generate has changed behavior so it fails if these are not supplied

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst peterbroadhurst requested a review from a team as a code owner December 13, 2023 13:13
@awrichar
Copy link
Contributor

Follow-on to #1432

@nguyer
Copy link
Contributor

nguyer commented Dec 13, 2023

@awrichar I think you accidentally linked to this PR where you said this was a follow-on to something else.

Haven't name and version always been required? For as long as I can remember I've always needed to take the output from /contracts/interfaces/generate and manually add a name and version if I didn't specify one in the original request before doing the POST to contracts/interfaces to create the FFI.

Do we have a link to what changed previously that requires this change now?

@nguyer
Copy link
Contributor

nguyer commented Dec 13, 2023

Okay after reading a bit more I realize that we now require a name and a version on /contracts/interfaces/generate which is somewhat new. This change makes those optional again (restoring existing behavior) by automatically filling them in with some default values. Sounds good to me.

@nguyer nguyer merged commit 4645f28 into main Dec 13, 2023
14 checks passed
@awrichar awrichar deleted the optional-name branch December 13, 2023 14:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants