Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update the FF manifest #1448

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Update the FF manifest #1448

merged 2 commits into from
Feb 15, 2024

Conversation

denisandreenko
Copy link
Member

No description provided.

@denisandreenko denisandreenko requested a review from a team as a code owner January 17, 2024 05:47
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d92165) 99.99% compared to head (2382992) 99.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1448      +/-   ##
==========================================
- Coverage   99.99%   99.96%   -0.04%     
==========================================
  Files         321      321              
  Lines       23108    23108              
==========================================
- Hits        23106    23099       -7     
- Misses          1        6       +5     
- Partials        1        3       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Dzianis Andreyenka <andreenkodn@gmail.com>
@nguyer
Copy link
Contributor

nguyer commented Feb 12, 2024

@denisandreenko It looks like there might be a compatibility issue between this build of Fabconnect that was pulled in and this build of FireFly core. I will look into that. Feel free to revert the Fabconnect portion of this change if you want the other one to go in. I'll sort through that issue in a separate PR.

@nguyer
Copy link
Contributor

nguyer commented Feb 12, 2024

Okay actually this issue is related to a recent change in how we build docker images (the user with which we run the app) but is already fixed in this PR for the FireFly CLI: hyperledger/firefly-cli#281

I just need a code review and merge on that one.

@denisandreenko
Copy link
Member Author

Sounds good, thanks @nguyer!
Don't merge it right after ff-cli PR merge.
I want to add bump up a tezosconnect version after merging this PR hyperledger/firefly-tezosconnect#32 and then I'll update this manifest.

Signed-off-by: Dzianis Andreyenka <andreenkodn@gmail.com>
@denisandreenko
Copy link
Member Author

@nguyer I've included the latest release of the tezosconnect.
Therefore, this PR can be merged whenever you see fit.

@nguyer nguyer merged commit 99a69ed into hyperledger:main Feb 15, 2024
14 checks passed
@denisandreenko denisandreenko deleted the manifest branch February 15, 2024 18:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants