Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update comment to reflect availability with WebSockets #1449

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

peterbroadhurst
Copy link
Contributor

Feature from #1447 wasn't reflected in this comment

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst peterbroadhurst requested a review from a team as a code owner January 19, 2024 20:19
@nguyer
Copy link
Contributor

nguyer commented Jan 23, 2024

Error: internal/coremsgs/en_struct_descriptions.go:1:17: Expected:2024, Actual: 2023

Signed-off-by: Nicko Guyer <nicko.guyer@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd542c0) 99.99% compared to head (0c9117d) 99.99%.
Report is 43 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1449   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         321      322    +1     
  Lines       23175    23273   +98     
=======================================
+ Hits        23173    23271   +98     
  Misses          1        1           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nguyer nguyer merged commit bab1bc4 into main Feb 12, 2024
14 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants