Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Large JSON number support for input params #1569

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Large JSON number support for input params #1569

merged 3 commits into from
Sep 6, 2024

Conversation

matthew1001
Copy link
Contributor

@matthew1001 matthew1001 commented Sep 6, 2024 •
edited
Loading

Preparing for a new FF release:

  • Updating to latest firefly-common and firefly-signer to pick up fixes including large JSON number parsing
  • Updating the manifest.json for all of the RC images

@matthew1001
Update firefly-common and firefly-signer
a5b8ec4 
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
@matthew1001 matthew1001 requested a review from a team as a code owner September 6, 2024 08:44
@matthew1001
Update docs
aa6f715 
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (74e2cbd) to head (5d5e488).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #1569   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          325       325           
  Lines        24055     24055           
=========================================
  Hits         24055     24055

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

EnriqueL8
EnriqueL8 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@matthew1001
Update manifest.json
5d5e488 
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
@matthew1001 matthew1001 changed the title Update firefly-common and firefly-signer Update firefly dependencies ready for new release candidate Sep 6, 2024
@EnriqueL8 EnriqueL8 added this to the v1.3.2 milestone Sep 6, 2024
@EnriqueL8 EnriqueL8 merged commit 4f64fd9 into hyperledger:main Sep 6, 2024
15 checks passed
@EnriqueL8 EnriqueL8 deleted the ff-deps branch September 6, 2024 10:34
@matthew1001 matthew1001 changed the title Update firefly dependencies ready for new release candidate Large number support Sep 12, 2024
@matthew1001 matthew1001 changed the title Large number support Large JSON number support for input params Sep 12, 2024
@matthew1001 matthew1001 mentioned this pull request Sep 18, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@EnriqueL8 EnriqueL8 EnriqueL8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@matthew1001 @EnriqueL8