Add Alloy-rs and remove ethers #85
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xPatryk
reviewed
Feb 14, 2025
| @@ -14,7 +14,12 @@ repository = "https://github.com/hyperliquid-dex/hyperliquid-rust-sdk" | |||
| [dependencies] | |||
| chrono = "0.4.26" | |||
| env_logger = "0.10.0" | |||
| ethers = {version = "2.0.14", features = ["eip712", "abigen"]} | |||
| alloy-primitives = { version = "0.8.21", features = ["serde"] } | |||
There was a problem hiding this comment.
Could you use alloy with features instead of everything as a single dependency?
It's easier for dependency management and you don't end up with a mess of dependencies.
Not 100% sure, but this should be it. Alloy core should have remaining deps
Suggested change
| alloy-primitives = { version = "0.8.21", features = ["serde"] } | |
| alloy = { version = "0.8", features = ["serde", "signer-local"] } |
There was a problem hiding this comment.
Yes I also agree with this, much cleaner this way
| @@ -1,49 +1,24 @@ | |||
| use alloy_primitives::{Address, U256}; | |||
| use alloy_signer_local::PrivateKeySigner; | |||
There was a problem hiding this comment.
And then use alloy::primitives:...
and so on
|
any breaking changes? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is reopened from : #84 but from an isolated fork branch for the work