Fix encryption in stream writer #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We store information about tables in table manifest. When stream writer would create a new table, it wouldn't store the key ID for the respective table in the manifest file. This commit fixes it.
jarifibrahim
requested review from
ashish-goswami and
manishrjain
as code owners
poonai
approved these changes
Dec 6, 2019
ashish-goswami
approved these changes
Dec 6, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain)
|
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We store information about tables in the table manifest. When stream
writer would create a new table, it wouldn't store the key ID for the
respective table in the manifest file. This commit fixes it.
Fixes #1144
This change is