Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(stream): add support for incremental stream writer #1722

Merged
merged 7 commits into from
Jul 6, 2021

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented Jul 5, 2021

This PR adds support for stream writing incrementally to the DB.
Adds an API: StreamWriter.PrepareIncremental


This change is Reviewable

@NamanJain8 NamanJain8 requested a review from manishrjain as a code owner July 5, 2021 19:02
@NamanJain8 NamanJain8 changed the title [BREAKING] feat(stream): add support for incremental stream writer feat(stream): add support for incremental stream writer Jul 6, 2021
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r3.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @NamanJain8)


stream_writer.go, line 98 at r3 (raw file):

	var once sync.Once

	// prepareToDrop will stop all the incomming write and flushes any pending flush tasks.

incoming


stream_writer.go, line 116 at r3 (raw file):

		if level.NumTables > 0 {
			sw.prevLevel = level.Level
		}

let's handle the case where there's no data.

@NamanJain8 NamanJain8 merged commit 725913b into master Jul 6, 2021
@NamanJain8 NamanJain8 deleted the mrjn/incremental-stream-writer branch July 6, 2021 16:12
mangalaman93 added a commit that referenced this pull request Feb 14, 2023
This PR adds support for stream writing incrementally to the DB.
Adds an API: StreamWriter.PrepareIncremental
mangalaman93 added a commit that referenced this pull request Feb 14, 2023
This PR adds support for stream writing incrementally to the DB.
Adds an API: StreamWriter.PrepareIncremental

This PR also has the bug fix from PR #1723.
mangalaman93 added a commit that referenced this pull request Feb 15, 2023
This PR adds support for stream writing incrementally to the DB.
Adds an API: StreamWriter.PrepareIncremental

This PR also has the bug fix from PR #1723.
mangalaman93 added a commit that referenced this pull request Feb 20, 2023
This PR adds support for stream writing incrementally to the DB.
Adds an API: StreamWriter.PrepareIncremental

This PR also has the bug fix from PR #1723.
mangalaman93 added a commit that referenced this pull request Feb 20, 2023
This PR adds support for stream writing incrementally to the DB.
Adds an API: StreamWriter.PrepareIncremental

This PR also has the bug fix from PR #1723.
mangalaman93 added a commit that referenced this pull request Feb 22, 2023
This PR adds support for stream writing incrementally to the DB.
Adds an API: StreamWriter.PrepareIncremental

This PR also has the bug fix from PR #1723.
mangalaman93 added a commit that referenced this pull request Feb 23, 2023
This PR adds support for stream writing incrementally to the DB.
Adds an API: StreamWriter.PrepareIncremental

This PR also has the bug fix from PR #1723.
mangalaman93 added a commit that referenced this pull request Feb 24, 2023
This PR adds support for stream writing incrementally to the DB.
Adds an API: StreamWriter.PrepareIncremental

This PR also has the bug fix from PR #1723.
mangalaman93 added a commit that referenced this pull request Mar 1, 2023
This PR adds support for stream writing incrementally to the DB.
Adds an API: StreamWriter.PrepareIncremental

This PR also has the bug fix from PR #1723.
mangalaman93 added a commit that referenced this pull request Mar 1, 2023
This PR adds support for stream writing incrementally to the DB.
Adds an API: StreamWriter.PrepareIncremental

This PR also has the bug fix from PR #1723.
mangalaman93 added a commit that referenced this pull request Mar 2, 2023
This PR adds support for stream writing incrementally to the DB.
Adds an API: StreamWriter.PrepareIncremental

This PR also has the bug fix from PR #1723.
mangalaman93 added a commit that referenced this pull request Mar 6, 2023
This PR adds support for stream writing incrementally to the DB.
Adds an API: StreamWriter.PrepareIncremental

This PR also has the bug fix from PR #1723.
mangalaman93 added a commit that referenced this pull request Mar 6, 2023
This PR adds support for stream writing incrementally to the DB.
Adds an API: StreamWriter.PrepareIncremental

This PR also has the bug fix from PR #1723.
mangalaman93 added a commit that referenced this pull request Mar 7, 2023
This PR adds support for stream writing incrementally to the DB.
Adds an API: StreamWriter.PrepareIncremental
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants