Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix the memory usage part of doc #1724

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Conversation

qichengzx
Copy link

@qichengzx qichengzx commented Jul 7, 2021

According to CHANGELOG.md#removed-apis. TableLoadingMode option is removed.
fixup the memory usage part of doc.


This change is Reviewable

…removed.

fixup the memory usage part of doc.
@qichengzx qichengzx requested a review from manishrjain as a code owner July 7, 2021 12:07
@CLAassistant
Copy link

CLAassistant commented Jul 7, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@NamanJain8 NamanJain8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @qichengzx , thanks for the fix. It would be great if you could remove ValueLoadingMode option doc a few lines above. That is also removed.

@NamanJain8 NamanJain8 merged commit 7879d23 into hypermodeinc:master Jul 8, 2021
joshua-goldstein added a commit that referenced this pull request Feb 9, 2023
mangalaman93 pushed a commit that referenced this pull request Feb 11, 2023
mangalaman93 pushed a commit that referenced this pull request Feb 14, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants