fix(bench): bring in benchmark fixes from main #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-goldstein
requested review from
akon-dey,
billprovince and
skrdgraph
as code owners
|
|
joshua-goldstein
force-pushed
the
joshua/bench
branch
from
e6eb700 to
6b0349a
Compare
mangalaman93
requested changes
Feb 19, 2023
badger/cmd/pick_table_bench.go
Outdated
| if err != nil { | ||
| return y.Wrapf(err, "unable to open DB") | ||
| } | ||
| defer db.Close() |
There was a problem hiding this comment.
let's log the warning here in case close fails
There was a problem hiding this comment.
replaced with
defer func() {
y.Check(db.Close())
}()
mangalaman93
approved these changes
Feb 23, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #1699 and #1741.