Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore(ci): fail fast when testing #1890

Merged
merged 7 commits into from
Feb 28, 2023
Merged

chore(ci): fail fast when testing #1890

merged 7 commits into from
Feb 28, 2023

Conversation

joshua-goldstein
Copy link
Contributor

Add failfast flag to go test commands in test.sh

@coveralls
Copy link

coveralls commented Feb 28, 2023 •
edited
Loading

Coverage Status

Coverage: 41.229%. Remained the same when pulling efc9ada on joshua/test into 0e2ebb1 on main.

@joshua-goldstein joshua-goldstein changed the base branch from main-deprecated-v4 to main February 28, 2023 20:21
skrdgraph
skrdgraph approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@skrdgraph skrdgraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - because the CI was failing silently before.

With the fixes we get an actual failure (which is what we want).

@joshua-goldstein joshua-goldstein merged commit d6c4dae into main Feb 28, 2023
@joshua-goldstein joshua-goldstein deleted the joshua/test branch February 28, 2023 20:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@skrdgraph skrdgraph skrdgraph approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@billprovince billprovince Awaiting requested review from billprovince

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshua-goldstein @coveralls @skrdgraph