Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(publisher): publish updates after persistence in WAL #1917

Merged
merged 1 commit into from
Apr 11, 2023
Merged

fix(publisher): publish updates after persistence in WAL #1917

merged 1 commit into from
Apr 11, 2023

Conversation

hugy718
Copy link
Contributor

@hugy718 hugy718 commented Mar 28, 2023

Problem

Fixes #1916

Solution

Moved the publisher sendUpdates() after insertion into the memtable WAL.

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mangalaman93 mangalaman93 merged commit 7304f02 into hypermodeinc:main Apr 11, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mangalaman93 mangalaman93

@harshil-goel harshil-goel

@akon-dey akon-dey

@billprovince billprovince

@joshua-goldstein joshua-goldstein

@skrdgraph skrdgraph

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QUESTION]: Publish before committing to WAL
4 participants
@hugy718 @CLAassistant @mangalaman93 @harshil-goel