Skip to content

add spotless rules for yaml #9

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2024
Merged

add spotless rules for yaml #9

merged 1 commit into from
Feb 17, 2024

Conversation

SrikarMannepalli
Copy link
Contributor

This adds yaml format files as well to the misc spotless targets

@SrikarMannepalli SrikarMannepalli requested a review from a team as a code owner February 12, 2024 10:24
aaron-steinfeld
aaron-steinfeld reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likely a breaking change, have you tested it? If so, bump major version on release

@SrikarMannepalli
Copy link
Contributor Author

likely a breaking change, have you tested it? If so, bump major version on release

Sure. I haven't yet tested it out. Will merge only after testing.

@SrikarMannepalli
Copy link
Contributor Author

Tested it out. It is working fine.

@SrikarMannepalli SrikarMannepalli merged commit 8d1f6d0 into main Feb 17, 2024
@SrikarMannepalli SrikarMannepalli deleted the SrikarMannepalli-patch-1 branch February 17, 2024 14:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@aaron-steinfeld aaron-steinfeld aaron-steinfeld left review comments

+1 more reviewer

@kishansairam9 kishansairam9 kishansairam9 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SrikarMannepalli @kishansairam9 @aaron-steinfeld