misc(payment): Add reasonCode to HyperwalletPayment #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
We (BlaBlaCar) recently activated the reasonCode field and we are facing an issue when parsing notifications with the HyperwalletPayment object (+ couldn't get the reasonCode) :
<#2f49d778> c.f.j.d.e.UnrecognizedPropertyException: Unrecognized field "reasonCode" (class com.hyperwallet.clientsdk.model.HyperwalletPayment), not marked as ignorable (14 known properties: "notes", "releaseOn", "createdOn", "destinationToken", "currency", "status", "expiresOn", "programToken", "clientPaymentId", "amount", "token", "memo", "purpose", "links"])There could probably be a workaround to avoid this error by skipping unknown fields on our Mapper, but we extended this POJO in our codebase as a workaround to add the reasonCode field which is quite useful for us.
Feel free to push on this branch or close this PR if not relevant
Thanks 🙏